Paths

Table of Contentst

Differential D25207

Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a Workboard Column
ClosedPublic
Actions

Authored by aklapper on May 9 2023, 13:31.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15373: PHP 8.1 "strlen(null)" exception blocks dragging a task to a workboard column

Commits

rPac4c95169973: Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a…

Summary

On a Workboard without any "Group by <something>", when moving a Task from a Column
to another, in PHP 8.1 there was a crash caused by a null passed to strlen().

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15373

Test Plan

Applied this change and afterwards dragging a Task card to another Column succeeded,
with or without a "Group by <something>" query.

Diff Detail

Repository

rP Phorge

Branch

workboardDrag (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 383
Build 383: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	95 ms	PhabricatorProjectCoreTestCase::testAncestorMembers EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	69 ms	PhabricatorProjectCoreTestCase::testColumnExtendedPolicies EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	70 ms	PhabricatorProjectCoreTestCase::testIsViewerMemberOrWatcher EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	97 ms	PhabricatorProjectCoreTestCase::testJoinLeaveProject EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	107 ms	PhabricatorProjectCoreTestCase::testMilestoneMembership EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
		View Full Test Results (6 Failed · 24 Passed)

Event Timeline

aklapper created this revision.May 9 2023, 13:31

Owners added a reviewer: O1: Blessed Committers.May 9 2023, 13:31

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 9 2023, 13:31

aklapper requested review of this revision.May 9 2023, 13:31

Harbormaster completed remote builds in B383: Diff 699.May 9 2023, 13:31

Tested locally, with and without "Group By <something>"

Hoping to be useful I expand the test plan, and I add a small inline documentation

Thanks again

sgtm

src/applications/project/controller/PhabricatorProjectMoveController.php
29	✅ I verified that the above line is just null or a string The function `phutil_nonempty_string()` will report any alien type, and that is OK.

This revision is now accepted and ready to land.May 9 2023, 16:29

add minor inline documentation

Harbormaster completed remote builds in B384: Diff 700.May 9 2023, 16:30

Thanks as usual!

valerio.bozzolan retitled this revision from Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a workboard column to Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a Workboard Column.May 9 2023, 16:37

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)

This revision was landed with ongoing or failed builds.May 9 2023, 16:37

Closed by commit rPac4c95169973: Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a…. · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPac4c95169973: Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a….

WHOA I hijacked your description just one millisecond before your land it seems

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

project/

controller/

PhabricatorProjectMoveController.php

2 lines

O1: Blessed Committers

Diff 699

View Options

src/applications/project/controller/PhabricatorProjectMoveController.php

Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a Workboard ColumnClosedPublicActions