Fix PHP 8.1 "strlen(null)" exception which blocks creating a blog post
ClosedPublic
Actions

Authored by aklapper on May 6 2023, 10:34.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15357: PHP 8.1 "strlen(null)" exception blocks creating a blog post

Commits

rPe5caf4333e5e: Fix PHP 8.1 "strlen(null)" exception which blocks creating a blog post

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15357

Test Plan

Applied this change and created blog post at /phame/post/view/3/blogpost/ rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

createBlogpost (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 367
Build 367: arc lint + arc unit

Event Timeline

aklapper created this revision.May 6 2023, 10:34

Owners added a reviewer: O1: Blessed Committers.May 6 2023, 10:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 6 2023, 10:34

aklapper requested review of this revision.May 6 2023, 10:34

Harbormaster completed remote builds in B367: Diff 671.May 6 2023, 10:34

Tested also this one, thanks

No implosions

sgtm

src/applications/phame/storage/PhamePost.php
70–71	✅ I verified the above line The line was split so to make the linter happy. I verified that `$blog->getDomain()` is never a `PhutilURI` but always is null or a string provided by the user. The function `phutil_nonempty_string()` will report any alien type, and that is OK.