Fix PHP 8.1 "strlen(null)" exception which blocks blog rendering
ClosedPublic
Actions

Authored by aklapper on May 6 2023, 10:23.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15356: PHP 8.1 "strlen(null)" exception blocks rendering a blog

Commits

rPeba8012d3e80: Fix PHP 8.1 "strlen(null)" exception which blocks blog rendering

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15356

Test Plan

Applied this change change on top of D25194 and /phame/blog/view/1/ rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

liveBlog (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 366
Build 366: arc lint + arc unit

Event Timeline

aklapper created this revision.May 6 2023, 10:23

Owners added a reviewer: O1: Blessed Committers.May 6 2023, 10:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 6 2023, 10:23

aklapper requested review of this revision.May 6 2023, 10:23

Harbormaster completed remote builds in B366: Diff 670.May 6 2023, 10:23

Thanks for this patch

I tested this patch locally, no implosions.

sgtm

src/applications/phame/controller/PhameLiveController.php
90	✅ I verified the above line The `$post_id` comes from getURIData() that just returns null or a string. The function `phutil_nonempty_string()` will report alien types, and that is OK.