Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules
ClosedPublic
Actions

Authored by aklapper on May 4 2023, 20:25.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15348: PHP 8.1 "strlen(null)" exception blocks creating personal and global Herald rules

Commits

rPb0044bad621b: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15348

Test Plan

Applied this change (on top of D25157) and creation form at /herald/edit/?content_type=HeraldPreCommitRefAdapter&rule_type=personal rendered in web browser.
Same applies for other types of personal and global Herald rules.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 4 2023, 20:25

Owners added a reviewer: O1: Blessed Committers.May 4 2023, 20:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 4 2023, 20:25

aklapper requested review of this revision.May 4 2023, 20:25

Harbormaster completed remote builds in B359: Diff 656.May 4 2023, 20:25

valerio.bozzolan edited the test plan for this revision. (Show Details)May 5 2023, 06:11

I tested this locally intensively creating a very weird entropy of possible Herald conditions. I also hacked my database manually, with dangerous fuzzy tests in the phabricator_herald.herald_condition database table, kind of:

INSERT INTO phabricator_hera.dherald_condition (id, ruleID,fieldName,fieldCondition,value) VALUES (NULL, 6, 'contentsource', 'is', '<VERY WEIRD STUFF>');