Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog
ClosedPublic
Actions

Authored by aklapper on Apr 30 2023, 18:15.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15311: PHP 8.1 "strlen(null)" exception blocks rendering Upload SSH Public key settings dialog

Commits

rPe3ad37f79259: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15311

Test Plan

Applied this change (on top of D25144, D25145, D25146, D25147, D25151,
D25152, D25153) and Upload SSH Public key dialog rendered in web browser.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 30 2023, 18:15

Owners added a reviewer: O1: Blessed Committers.Apr 30 2023, 18:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 30 2023, 18:15

aklapper requested review of this revision.Apr 30 2023, 18:15

Harbormaster completed remote builds in B311: Diff 583.Apr 30 2023, 18:15

Thanks

Tested locally creating SSH key with and without a name. No implosions! Yuppie!

yesyes

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php
57	✅ I checked `$v_name` with `phlog()` to verify that the input domain was `null` or a string. The `phutil_nonempty_string()` will report alien values and that is OK.