Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception which blocks rendering creation form pages for Legalpad, Macro, Settings
ClosedPublic

Authored by aklapper on Apr 30 2023, 12:43.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15309

Test Plan

Applied this change (on top of D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154, D25155, D25156, D25158 locally applied)
and the pages /legalpad/edit/, /macro/create/, /settings/builtin/global/
rendered in web browser.

Diff Detail

Repository
rP Phorge
Branch
D25159 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 307
Build 307: arc lint + arc unit

Event Timeline

Tested in PHP 8.1. It works. No explosions.

yesyes

src/applications/transactions/editengine/PhabricatorEditEngine.php
944

✅ I logged $form_key to check its values and its domain seems to be NULL or strings like default. Alien values will be reported by phutil_nonempty_string() and this is OK.

This revision is now accepted and ready to land.Apr 30 2023, 15:24