Fix information page about Read-only status
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 24 2023, 08:41.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

This change fixes the following page on your Phorge/Phabricator:

/readonly/config/

If you visit that page (with or without read-only mode), the
following crash will happen:

Call to undefined method PlatformSymbols::getPlatformServerSymbol()

For more information:

Probably the regression was introduced in this point:

Test Plan

Visit the page /readonly/config/
It does not crash anymore and you can see that beautiful message that - it seems - no person in the world has ever seen since a whole year. Take a good look at this page: it is a precious treasure.

Repository

rP Phorge

Branch

config-readonly

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 167
Build 167: arc lint + arc unit

	Time	Test
	829 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	898 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	226 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	222 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
	1,306 ms	PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed.
		View Full Test Results (1 Failed · 6 Passed)