Page MenuHomePhorge

Fix some invalid PhpDoc
ClosedPublic

Authored by aklapper on Sat, Jun 14, 18:06.
Tags
None
Referenced Files
F5517184: D26086.1750170527.diff
Mon, Jun 16, 14:28
F5505469: D26086.1750149827.diff
Mon, Jun 16, 08:43
F5490671: D26086.1750128039.diff
Mon, Jun 16, 02:40
F5490467: D26086.1750127729.diff
Mon, Jun 16, 02:35
F5490466: D26086.1750127727.diff
Mon, Jun 16, 02:35
F5488276: D26086.1750124031.diff
Mon, Jun 16, 01:33
F5487706: D26086.1750123144.diff
Mon, Jun 16, 01:19
F5472075: D26086.1750094651.diff
Sun, Jun 15, 17:24

Details

Summary

Fix invalid syntax etc.

Test Plan

Compare PHPDoc and signature; run static code analysis.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mainframe98 added inline comments.
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
923

Do as mainframe98 rightfully says, plus fix two further issues.
Cannot avoid going above the 80 chars per line limit as PHPStan otherwise complains about a * being parsed

Some of these array type hints feel sketchy, but they already were unusual. I suppose this is fine. The rest certainly is.

This revision is now accepted and ready to land.Sun, Jun 15, 08:02
This revision was automatically updated to reflect the committed changes.