Fix invalid syntax etc.
Details
Details
- Reviewers
mainframe98 - Group Reviewers
O1: Blessed Committers - Commits
- rPa19ab9e75c30: Fix some invalid PhpDoc
Compare PHPDoc and signature; run static code analysis.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phpdocinvalid (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2107 Build 2107: arc lint + arc unit
Event Timeline
| src/applications/auth/engine/PhabricatorAuthSessionEngine.php | ||
|---|---|---|
| 923 | ||
Comment Actions
Do as mainframe98 rightfully says, plus fix two further issues.
Cannot avoid going above the 80 chars per line limit as PHPStan otherwise complains about a * being parsed
Comment Actions
Some of these array type hints feel sketchy, but they already were unusual. I suppose this is fine. The rest certainly is.