Page MenuHomePhorge

Remove checks for random_bytes and openssl_random_pseudo_bytes
ClosedPublic

Authored by aklapper on Mon, Jun 9, 12:28.

Details

Summary

Per https://www.php.net/manual/en/function.random-bytes.php, random_bytes() has been available since PHP 7.0.
(And per https://www.php.net/manual/en/function.openssl-random-pseudo-bytes.php, openssl_random_pseudo_bytes() has been available since PHP 5.3.0 but that's irrelevant here.)
Phorge requires PHP 7.2 since rP7d8c84a7bdc8fb43674341b97c36c9d8ae1d894a so also remove these pre-PHP 7.2 checks in Arcanist.

Test Plan

Read the code.

Diff Detail

Repository
rARC Arcanist
Branch
php530openssl (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2077
Build 2077: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.Mon, Jun 9, 12:28

Also bump PHP version check in support/init/init-script.php

Bump PHP version also in .arclint

To the CentOS 7 user surfing to this patch: please kill your server with as much violence as possible, since your server is a security hole with software around.

This revision is now accepted and ready to land.Thu, Jun 12, 07:18