Per https://www.php.net/manual/en/function.random-bytes.php, random_bytes() has been available since PHP 7.0.
(And per https://www.php.net/manual/en/function.openssl-random-pseudo-bytes.php, openssl_random_pseudo_bytes() has been available since PHP 5.3.0 but that's irrelevant here.)
Phorge requires PHP 7.2 since rP7d8c84a7bdc8fb43674341b97c36c9d8ae1d894a so also remove these pre-PHP 7.2 checks in Arcanist.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rARC92091b3130c5: Remove checks for random_bytes and openssl_random_pseudo_bytes
Read the code.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- php530openssl (branched from master)
- Lint
Lint Errors Severity Location Code Message Error src/filesystem/Filesystem.php:447 XHP45 PHP Compatibility - Unit
Tests Passed - Build Status
Buildable 2075 Build 2075: arc lint + arc unit
Event Timeline
Comment Actions
To the CentOS 7 user surfing to this patch: please kill your server with as much violence as possible, since your server is a security hole with software around.