Page MenuHomePhorge

a11y: Do not mark top bar notifications area as aria-hidden
AcceptedPublic

Authored by aklapper on Sun, Jun 1, 11:44.

Details

Summary

Do not the mark main alerts/notifications area as aria-hidden.
Focusable descendents within an [aria-hidden="true"] element prevent those interactive elements from being available to users of assistive technologies like screen readers.

As can be seen in the code of PhabricatorMainMenuView, all three icons already define some $aural[] array to include output for assistive technologies, so their parent element should not block accessing that output.

Ref T16072

Test Plan
  • Go to http://phorge.localhost/ and inspect the <div class="phabricator-main-menu-alerts"> element and its descendents.
  • Ideally, check with some screenreader sofware. I didn't.
  • Optionally, run an Accessibility check in Chromium Lighthouse.

Diff Detail

Repository
rP Phorge
Branch
a11y-T16072-10 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2043
Build 2043: arc lint + arc unit