Paths

Table of Contentst

Differential D26047

a11y: Add "title" to <a> tags of PHUIObjectItemView images
AcceptedPublic
Actions

Authored by aklapper on Sun, Jun 1, 11:29.

Details

Reviewers

chris

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16072: Accessibility improvements (June 2025)

Summary

Links should have a discernible name per https://dequeuniversity.com/rules/axe/4.10/link-name

PhabricatorRepositorySearchEngine::renderResultList() renders PHUIObjectItemView objects, thus add title parameters to <a> links.

Ref T16072

Test Plan

Go to http://phorge.localhost/diffusion/ and inspect the <a> element surrounding the folder icon link for each listed repository.
Optionally, run an Accessibility check in Chromium Lighthouse.

Diff Detail

Repository

rP Phorge

Branch

a11y-T16072-04 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2037
Build 2037: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Jun 1, 11:29

Owners added a reviewer: O1: Blessed Committers.Sun, Jun 1, 11:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Jun 1, 11:29

aklapper requested review of this revision.Sun, Jun 1, 11:29

Harbormaster completed remote builds in B2037: Diff 3132.Sun, Jun 1, 11:29

chris accepted this revision.Sun, Jun 1, 13:41

This revision is now accepted and ready to land.Sun, Jun 1, 13:41

aklapper edited the summary of this revision. (Show Details)Sun, Jun 1, 14:30

aklapper added a task: T16072: Accessibility improvements (June 2025).

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

view/

phui/

PHUIObjectItemView.php

1 line

O1: Blessed Committers

Diff 3132

View Options

src/view/phui/PHUIObjectItemView.php

a11y: Add "title" to <a> tags of PHUIObjectItemView imagesAcceptedPublicActions