Paths

Table of Contentst

Differential D26046

a11y: Add aria-label to calendar date picker button
AcceptedPublic
Actions

Authored by aklapper on Sun, Jun 1, 11:26.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16072: Accessibility improvements (June 2025)

Summary

Form elements should have associated labels per https://www.w3.org/WAI/tutorials/forms/labels/

Test Plan

Have a custom field of "type": "date" defined in /config/edit/maniphest.custom-field-definitions/.
Go to edit a task (/maniphest/task/edit/1/) whose form exposes that custom field.
Inspect the <a> field parameters with class="calendar-button" and see an additional aria-label="Calendar date picker".
Optionally, run an Accessibility check in Chromium Lighthouse.

Diff Detail

Repository

Branch

a11y-T16072-03 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2036
Build 2036: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Jun 1, 11:26

Owners added a reviewer: O1: Blessed Committers.Sun, Jun 1, 11:26

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Jun 1, 11:26

aklapper requested review of this revision.Sun, Jun 1, 11:26

Harbormaster completed remote builds in B2036: Diff 3131.Sun, Jun 1, 11:26

chris accepted this revision.Sun, Jun 1, 13:40

This revision is now accepted and ready to land.Sun, Jun 1, 13:40

aklapper edited the summary of this revision. (Show Details)Sun, Jun 1, 14:30

aklapper added a task: T16072: Accessibility improvements (June 2025).

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

view/

form/

control/

AphrontFormDateControl.php

7 lines

0%

Loading...

O1: Blessed Committers

Diff 3131

src/view/form/control/AphrontFormDateControl.php

Loading...