Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence
ClosedPublic
Actions

Authored by aklapper on Wed, May 7, 13:29.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence

Commits

rP66bad4e5eebe: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:58]

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:73]

Closes T16062

Test Plan

Go to a Conpherence room and search for an existing string.