Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence
ClosedPublic

Authored by aklapper on Wed, May 7, 13:29.
Tags
None
Referenced Files
F4116796: D25994.1746972948.diff
Sat, May 10, 14:15
F4115823: D25994.1746954067.diff
Sat, May 10, 09:01
F4115550: D25994.1746948377.diff
Sat, May 10, 07:26
F4114047: D25994.1746940040.diff
Sat, May 10, 05:07
F4113891: D25994.1746939309.diff
Sat, May 10, 04:55
F4110833: D25994.1746924595.diff
Sat, May 10, 00:49
F4110311: D25994.1746908606.diff
Fri, May 9, 20:23
F4110232: D25994.1746905770.diff
Fri, May 9, 19:36

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:58]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:73]

Closes T16062

Test Plan

Go to a Conpherence room and search for an existing string.

Diff Detail

Repository
rP Phorge
Branch
php8T16062 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1947
Build 1947: arc lint + arc unit