Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence
ClosedPublic

Authored by aklapper on Wed, May 7, 13:29.
Tags
None
Referenced Files
F4110311: D25994.1746908606.diff
Fri, May 9, 20:23
F4110232: D25994.1746905770.diff
Fri, May 9, 19:36
F4103493: D25994.1746901550.diff
Fri, May 9, 18:25
F4102939: D25994.1746901287.diff
Fri, May 9, 18:21
F4102924: D25994.1746901268.diff
Fri, May 9, 18:21
F4097219: D25994.1746898947.diff
Fri, May 9, 17:42
F4077060: D25994.1746885143.diff
Fri, May 9, 13:52
F4046873: D25994.1746742640.diff
Wed, May 7, 22:17

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:58]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceFulltextQuery.php:73]

Closes T16062

Test Plan

Go to a Conpherence room and search for an existing string.

Diff Detail

Repository
rP Phorge
Branch
php8T16062 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1947
Build 1947: arc lint + arc unit