Paths

Table of Contentst

Differential D25979

Fix invalid return values for void
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 29, 11:21.

Tags

None

Referenced Files

	F3912373: D25979.1746343968.diff
	Sat, May 3, 07:32

	F3896242: D25979.1746287255.diff
	Fri, May 2, 15:47

	F3890513: D25979.1746267707.diff
	Fri, May 2, 10:21

	F3890108: D25979.1746260698.diff
	Fri, May 2, 08:24

	F3883134: D25979.1746251334.diff
	Fri, May 2, 05:48

	F3882725: D25979.1746245420.diff
	Fri, May 2, 04:10

	F3859228: D25979.1746169947.diff
	Thu, May 1, 07:12

	F3828255: D25979.1746052938.diff
	Tue, Apr 29, 22:42

View All 9 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPc51002398d63: Fix invalid return values for void

Summary

Remove or correct wrong @return types in PHPDoc and/or correct wrong return values in methods.

Test Plan

Run static code analysis; read code; check method in parent class and other callers, etc.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Apr 29, 11:21

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 29, 11:21

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 29, 11:21

aklapper requested review of this revision.Tue, Apr 29, 11:21

Harbormaster completed remote builds in B1901: Diff 2937.Tue, Apr 29, 11:21

valerio.bozzolan added inline comments.Tue, Apr 29, 14:38

src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php
36–37	At this point this return can be dropped, with an evil laugh
src/applications/search/query/PhabricatorSearchDocumentQuery.php
107–108	At this point this return can be dropped, with an evil laugh ✅ P.S. I verified that nothing calls `->nextPage()->something()`
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
76–77	At this point this return can be dropped, with an evil laugh

Remove "return;" lines

Harbormaster completed remote builds in B1907: Diff 2944.Tue, Apr 29, 20:04

lgtm

This revision is now accepted and ready to land.Tue, Apr 29, 21:12

aklapper marked 3 inline comments as done.Wed, Apr 30, 06:49

Closed by commit rPc51002398d63: Fix invalid return values for void. · Explain WhyWed, Apr 30, 06:50

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc51002398d63: Fix invalid return values for void.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

drydock/

worker/

DrydockLeaseUpdateWorker.php

2 lines

O1: Blessed Committers

metamta/

storage/

PhabricatorMetaMTAMail.php

2 lines

O1: Blessed Committers

people/

phid/

PhabricatorPeopleUserEmailPHIDType.php

2 lines

O1: Blessed Committers

search/

query/

PhabricatorSearchDocumentQuery.php

1 line

O1: Blessed Committers

infrastructure/

customfield/

field/

PhabricatorCustomField.php

2 lines

O1: Blessed Committers

PhabricatorCustomFieldList.php

2 lines

O1: Blessed Committers

daemon/

workers/

query/

PhabricatorWorkerTriggerQuery.php

1 line

O1: Blessed Committers

storage/

PhabricatorWorkerTrigger.php

1 line

O1: Blessed Committers

Diff 2949

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php

Loading...

src/applications/search/query/PhabricatorSearchDocumentQuery.php

Loading...

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Loading...