Page MenuHomePhorge

Remove an unneeded condition in PHUITimelineEventView.php
ClosedPublic

Authored by aklapper on Sun, Apr 27, 10:56.

Details

Summary

Since rP40e9806e3c88500a67d382a5ec07594325f1b000 changing if ($items || $has_menu) to if ($items), the ternary operator condition $items ? 'a' : 'span' is always true.

Test Plan

Read the code; run static code analysis.

Diff Detail

Repository
rP Phorge
Branch
ternaryAlwaysTrue (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1895
Build 1895: arc lint + arc unit

Event Timeline

valerio.bozzolan added inline comments.
src/view/phui/PHUITimelineEventView.php
351

lol also this is nonsense probably

This revision is now accepted and ready to land.Sun, Apr 27, 19:10

oh true that! sigh I should look around a bit more