Page MenuHomePhorge
Differential D25976

Remove an unneeded condition in PHUITimelineEventView.php
ClosedPublic
Actions

Authored by aklapper on Sun, Apr 27, 10:56.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP3cf47d2cb6b1: Remove an unneeded condition in PHUITimelineEventView.php
Summary

Since rP40e9806e3c88500a67d382a5ec07594325f1b000 changing if ($items || $has_menu) to if ($items), the ternary operator condition $items ? 'a' : 'span' is always true.

Test Plan

Read the code; run static code analysis.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Sun, Apr 27, 10:56
Owners added a reviewer: O1: Blessed Committers.Sun, Apr 27, 10:56
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Apr 27, 10:56
aklapper requested review of this revision.Sun, Apr 27, 10:56
Harbormaster completed remote builds in B1895: Diff 2926.Sun, Apr 27, 10:56
valerio.bozzolan accepted this revision.Sun, Apr 27, 19:10
valerio.bozzolan added inline comments.
src/view/phui/PHUITimelineEventView.php
351

lol also this is nonsense probably

This revision is now accepted and ready to land.Sun, Apr 27, 19:10
aklapper updated this revision to Diff 2930.Sun, Apr 27, 23:33

oh true that! sigh I should look around a bit more

Harbormaster completed remote builds in B1898: Diff 2930.Sun, Apr 27, 23:33
aklapper marked an inline comment as done.Sun, Apr 27, 23:33
valerio.bozzolan accepted this revision.Mon, Apr 28, 05:42

lgtm

Closed by commit rP3cf47d2cb6b1: Remove an unneeded condition in PHUITimelineEventView.php. · Explain WhyMon, Apr 28, 06:31
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP3cf47d2cb6b1: Remove an unneeded condition in PHUITimelineEventView.php.

Revision Contents
Changeset List

PathSizePackages
src/
view/
phui/
10 linesO1: Blessed Committers

Diff 2931

View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0