Remove setup check for safe_mode removed in PHP 5.4
ClosedPublic
Actions

Authored by aklapper on Apr 5 2025, 13:39.

Tags

None

Referenced Files

	F3936542: D25947.1746421534.diff
	Sun, May 4, 05:05

	F3936536: D25947.1746421513.diff
	Sun, May 4, 05:05

	F3648374: D25947.1745422262.diff
	Tue, Apr 22, 15:31

	F3575218: D25947.1745004358.diff
	Thu, Apr 17, 19:25

	F3575192: D25947.1745002150.diff
	Thu, Apr 17, 18:49

	F3553709: D25947.1744953881.diff
	Thu, Apr 17, 05:24

	F3552892: D25947.1744911202.diff
	Wed, Apr 16, 17:33

	F3527462: D25947.1744840690.diff
	Tue, Apr 15, 21:58

Subscribers

Details

Reviewers

mainframe98
avivey

Group Reviewers

O1: Blessed Committers

Commits

rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4

Summary

Phorge requires PHP 7.2 so don't check for stuff removed in PHP 5.4.
See https://www.php.net/releases/5_4_0.php and https://web.archive.org/web/20190217003515/https://php.net/features.safe-mode

Test Plan

Set up Phorge, I'd guess.

Diff Detail

Repository

rP Phorge

Branch

rmPhp55check (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1846
Build 1846: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 5 2025, 13:39

Owners added a reviewer: O1: Blessed Committers.Apr 5 2025, 13:39

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 5 2025, 13:39

aklapper requested review of this revision.Apr 5 2025, 13:39

Harbormaster completed remote builds in B1842: Diff 2834.Apr 5 2025, 13:39

git rebase master

Harbormaster completed remote builds in B1846: Diff 2839.Apr 5 2025, 14:05

Setup phorge, saw nothing unusual in the setup issues.

avivey accepted this revision.Mon, Apr 7, 06:08

This revision is now accepted and ready to land.Mon, Apr 7, 06:08

Closed by commit rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4. · Explain WhyMon, Apr 7, 20:12

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.

aklapper mentioned this in Next Up.Mon, Apr 7, 20:13

avivey mentioned this in 2025.18.Fri, May 2, 11:35

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

19 lines

O1: Blessed Committers

Diff 2839

View Options

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Remove setup check for safe_mode removed in PHP 5.4ClosedPublicActions