Paths

Table of Contentst

Differential D25949

Complete session digest migration from SHA1 to SHA256
ClosedPublic
Actions

Authored by aklapper on Apr 5 2025, 14:00.

Tags

None

Referenced Files

	F3878251: D25949.1746219783.diff
	Thu, May 1, 21:03

	F3605089: D25949.1745251527.diff
	Sun, Apr 20, 16:05

	F3604540: D25949.1745208804.diff
	Sun, Apr 20, 04:13

	F3552855: D25949.1744909737.diff
	Wed, Apr 16, 17:08

	F3552466: D25949.1744904296.diff
	Wed, Apr 16, 15:38

	F3531486: D25949.1744883255.diff
	Wed, Apr 16, 09:47

	F3526709: D25949.1744832284.diff
	Tue, Apr 15, 19:38

	F3408829: D25949.1744596928.diff
	Sun, Apr 13, 02:15

View All 29 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256

Commits

rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256

Summary

Followup to 1d34238dc94555466e15039ff6991b371ae294ef.
Crossing fingers that nobody complains about a one-time logout after their six year long user session.

Closes T16025

Test Plan

Log in, log out, do stuff.
More specifically, with my session expired, successfully logging in created a database row added to phabricator_user.phabricator_session as expected, and logout removed the row.

Diff Detail

Repository

Branch

T16025authSha1 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1844
Build 1844: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 5 2025, 14:00

Owners added a reviewer: O1: Blessed Committers.Apr 5 2025, 14:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 5 2025, 14:00

aklapper requested review of this revision.Apr 5 2025, 14:00

Harbormaster completed remote builds in B1844: Diff 2836.Apr 5 2025, 14:00

Sure, 7 years is probably long enough to migrate cookies.

This revision is now accepted and ready to land.Apr 6 2025, 06:53

aklapper edited the test plan for this revision. (Show Details)Mon, Apr 7, 20:43

Closed by commit rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256. · Explain WhyMon, Apr 7, 21:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

25 lines

0%

Loading...

O1: Blessed Committers

Diff 2836

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...