Page MenuHomePhorge
Differential D25909

Diviner: Contributing Code: Update section on Prototype Changes
ClosedPublic
Actions

Authored by aklapper on Sun, Mar 16, 20:40.
Tags
None
Referenced Files
F3388444: D25909.1744446932.diff
Fri, Apr 11, 08:35
F3388438: D25909.1744446920.diff
Fri, Apr 11, 08:35
F3388436: D25909.1744446916.diff
Fri, Apr 11, 08:35
F3388432: D25909.1744446905.diff
Fri, Apr 11, 08:35
F3364760: D25909.1744160273.diff
Tue, Apr 8, 00:57
F3360981: D25909.1744013784.diff
Sun, Apr 6, 08:16
F3360002: D25909.1743968173.diff
Sat, Apr 5, 19:36
F3355921: D25909.1743878239.diff
Fri, Apr 4, 18:37
View All 28 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16007: Discuss the policy for contributing to prototype applications
Commits
rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes
Summary

Per discussion in T16007 I hope that we can agree on this phrasing.

Closes T16007

Test Plan

Look at the reality out there.

Diff Detail

Repository
rP Phorge
Branch
T16007proto (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1782
Build 1782: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Mar 16, 20:40
Owners added a reviewer: O1: Blessed Committers.Sun, Mar 16, 20:40
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Mar 16, 20:40
aklapper requested review of this revision.Sun, Mar 16, 20:40
Harbormaster completed remote builds in B1781: Diff 2746.Sun, Mar 16, 20:40
aklapper updated this revision to Diff 2747.Sun, Mar 16, 20:42

where did my closing brakets go?

Harbormaster completed remote builds in B1782: Diff 2747.Sun, Mar 16, 20:42
Cigaryno mentioned this in D25905: Remove No Prototype Changes section from Contributing Code document.Sun, Mar 16, 20:46
valerio.bozzolan accepted this revision.Wed, Mar 19, 13:57

Thaanks - please wait 7 days + 1 hour + 1 second + 42 milliseconds before landing to attract more Pòkèmòn reviewers

sgtm

This revision is now accepted and ready to land.Wed, Mar 19, 13:57
Closed by commit rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes. · Explain WhyWed, Mar 26, 16:15
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes.

Revision Contents
Changeset List

PathSizePackages
src/
docs/
contributor/
14 linesO1: Blessed Committers

Diff 2747

View Options

src/docs/contributor/contributing_code.diviner

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0