Page MenuHomePhorge
Differential D25909

Diviner: Contributing Code: Update section on Prototype Changes
ClosedPublic
Actions

Authored by aklapper on Mar 16 2025, 20:40.
Tags
None
Referenced Files
F4073365: D25909.1746856721.diff
Fri, May 9, 05:58
F3675727: D25909.1745520026.diff
Wed, Apr 23, 18:40
F3675532: D25909.1745514750.diff
Wed, Apr 23, 17:12
F3672062: D25909.1745471340.diff
Wed, Apr 23, 05:09
F3667089: D25909.1745465935.diff
Wed, Apr 23, 03:38
F3648166: D25909.1745417572.diff
Tue, Apr 22, 14:12
F3571851: D25909.1744998016.diff
Thu, Apr 17, 17:40
F3552798: D25909.1744908119.diff
Wed, Apr 16, 16:41
View All 41 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16007: Discuss the policy for contributing to prototype applications
Commits
rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes
Summary

Per discussion in T16007 I hope that we can agree on this phrasing.

Closes T16007

Test Plan

Look at the reality out there.

Diff Detail

Repository
rP Phorge
Branch
T16007proto (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1781
Build 1781: arc lint + arc unit

Event Timeline

aklapper created this revision.Mar 16 2025, 20:40
Owners added a reviewer: O1: Blessed Committers.Mar 16 2025, 20:40
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 16 2025, 20:40
aklapper requested review of this revision.Mar 16 2025, 20:40
Harbormaster completed remote builds in B1781: Diff 2746.Mar 16 2025, 20:40
aklapper updated this revision to Diff 2747.Mar 16 2025, 20:42

where did my closing brakets go?

Harbormaster completed remote builds in B1782: Diff 2747.Mar 16 2025, 20:42
Cigaryno mentioned this in D25905: Remove No Prototype Changes section from Contributing Code document.Mar 16 2025, 20:46
valerio.bozzolan accepted this revision.Mar 19 2025, 13:57

Thaanks - please wait 7 days + 1 hour + 1 second + 42 milliseconds before landing to attract more Pòkèmòn reviewers

sgtm

This revision is now accepted and ready to land.Mar 19 2025, 13:57
Closed by commit rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes. · Explain WhyMar 26 2025, 16:15
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes.

Revision Contents
Changeset List

PathSizePackages
src/
docs/
contributor/
14 linesO1: Blessed Committers

Diff 2746

View Options

src/docs/contributor/contributing_code.diviner

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0