- Remove the section No Prototype Changes from Contributing Code
- Mention that users should add as a reviewer O1 Blessed Committers instead of #blessed_reviewers as a reviewer
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers
Double check the documentation
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1768 Build 1768: arc lint + arc unit
Event Timeline
| src/docs/contributor/contributing_code.diviner | ||
|---|---|---|
| 167 | Whoops. I made a typo. | |
Comment Actions
@Cigaryno please create a task under Discussion Needed for this - I'm not sure we want to make this policy change.
Comment Actions
I agree on discussing the removal of this phrase. I will wait the task, but my opinion is that it's a legacy phrase from a company that had better to do than fixing weird workflows based on Prototypes (and it had sense). But now it's a community and we already work on best effort on everything, including prototypes. Moreover that phrase does not reflect the current situation, since we triaged and fixed 6 bugs on the Calendar prototype Calendar (even if it should be un-prototyped one day) - and probably more evident already-reviewed patches.
Comment Actions
In the meanwhile I paste here a proposed alternative that may better reflect the current situation (no need to update the patch - since I guess this phrase will attract more changes):
Prototype Changes
We generally advise against submitting patches for prototype applications, as they are often subject to significant changes and may not be widely adopted and may need extra care from rare users who are particularly familiar with them. For the same reasons, we also discourage feature requests or bug reports for these applications, unless you are very familiar with their original design and their original workflows. As always, you can open a question in Ponder instead. To learn more about prototype applications, see
User Guide: Prototype Applications.