Page MenuHomePhorge
Differential D25884

Add some trivial Herald related PhpDoc comments
ClosedPublic
Actions

Authored by aklapper on Feb 16 2025, 23:34.
Tags
None
Referenced Files
F4011888: D25884.1746626853.diff
Tue, May 6, 14:07
F3954815: D25884.1746457256.diff
Sun, May 4, 15:00
F3761281: D25884.1745830991.diff
Sun, Apr 27, 09:03
F3738966: D25884.1745762802.diff
Sat, Apr 26, 14:06
F3738954: D25884.1745762461.diff
Sat, Apr 26, 14:01
F3695562: D25884.1745591861.diff
Thu, Apr 24, 14:37
F3689813: D25884.1745590836.diff
Thu, Apr 24, 14:20
F3689799: D25884.1745590211.diff
Thu, Apr 24, 14:10
View All 99 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPf9e5630bab68: Add some trivial Herald related PhpDoc comments
Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1722
Build 1722: arc lint + arc unit

Event Timeline

aklapper created this revision.Feb 16 2025, 23:34
Owners added a reviewer: O1: Blessed Committers.Feb 16 2025, 23:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 16 2025, 23:34
aklapper requested review of this revision.Feb 16 2025, 23:34
Harbormaster completed remote builds in B1716: Diff 2661.Feb 16 2025, 23:34
aklapper updated this revision to Diff 2662.Feb 16 2025, 23:36

I wonder what's wrong with my CSS/JS, sigh

Harbormaster completed remote builds in B1717: Diff 2662.Feb 16 2025, 23:36
aklapper added a comment.Feb 17 2025, 00:01

Okay, got to wait until D25885 is merged first

valerio.bozzolan accepted this revision.Feb 17 2025, 07:16

yesyes

This revision is now accepted and ready to land.Feb 17 2025, 07:16
aklapper updated this revision to Diff 2668.Feb 17 2025, 08:33

git rebase master

Harbormaster completed remote builds in B1722: Diff 2668.Feb 17 2025, 08:33
Closed by commit rPf9e5630bab68: Add some trivial Herald related PhpDoc comments. · Explain WhyFeb 17 2025, 08:34
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf9e5630bab68: Add some trivial Herald related PhpDoc comments.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
herald/
action/
3 lines1%
Loading...
O1: Blessed Committers
engine/
16 lines11%
Loading...
O1: Blessed Committers
storage/
3 lines12%
Loading...
O1: Blessed Committers

Diff 2668

View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/engine/HeraldEffect.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0