Page MenuHomePhorge
Differential D25884

Add some trivial Herald related PhpDoc comments
ClosedPublic
Actions

Authored by aklapper on Sun, Feb 16, 23:34.
Tags
None
Referenced Files
F2991598: D25884.1740194691.diff
Fri, Feb 21, 03:24
F2988997: D25884.1740162427.diff
Thu, Feb 20, 18:27
F2988329: D25884.1740145181.diff
Thu, Feb 20, 13:39
F2984653: D25884.1740021073.diff
Wed, Feb 19, 03:11
F2983735: D25884.1739999048.diff
Tue, Feb 18, 21:04
F2982836: D25884.1739971965.diff
Tue, Feb 18, 13:32
F2982745: D25884.1739971749.diff
Tue, Feb 18, 13:29
F2981661: D25884.1739921451.diff
Mon, Feb 17, 23:30
View All 21 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPf9e5630bab68: Add some trivial Herald related PhpDoc comments
Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1722
Build 1722: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Feb 16, 23:34
Owners added a reviewer: O1: Blessed Committers.Sun, Feb 16, 23:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Feb 16, 23:34
aklapper requested review of this revision.Sun, Feb 16, 23:34
Harbormaster completed remote builds in B1716: Diff 2661.Sun, Feb 16, 23:34
aklapper updated this revision to Diff 2662.Sun, Feb 16, 23:36

I wonder what's wrong with my CSS/JS, sigh

Harbormaster completed remote builds in B1717: Diff 2662.Sun, Feb 16, 23:36
aklapper added a comment.Mon, Feb 17, 00:01

Okay, got to wait until D25885 is merged first

valerio.bozzolan accepted this revision.Mon, Feb 17, 07:16

yesyes

This revision is now accepted and ready to land.Mon, Feb 17, 07:16
aklapper updated this revision to Diff 2668.Mon, Feb 17, 08:33

git rebase master

Harbormaster completed remote builds in B1722: Diff 2668.Mon, Feb 17, 08:33
Closed by commit rPf9e5630bab68: Add some trivial Herald related PhpDoc comments. · Explain WhyMon, Feb 17, 08:34
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf9e5630bab68: Add some trivial Herald related PhpDoc comments.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
herald/
action/
3 lines1%
Loading...
O1: Blessed Committers
engine/
16 lines11%
Loading...
O1: Blessed Committers
storage/
3 lines12%
Loading...
O1: Blessed Committers

Diff 2668

View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/engine/HeraldEffect.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0