Page MenuHomePhorge
Differential D25884

Add some trivial Herald related PhpDoc comments
ClosedPublic
Actions

Authored by aklapper on Feb 16 2025, 23:34.
Tags
None
Referenced Files
F3302132: D25884.1743062601.diff
Wed, Mar 26, 08:03
F3298147: D25884.1742997697.diff
Tue, Mar 25, 14:01
F3293780: D25884.1742922315.diff
Mon, Mar 24, 17:05
F3290203: D25884.1742861829.diff
Mon, Mar 24, 00:17
F3289647: D25884.1742850414.diff
Sun, Mar 23, 21:06
F3283911: D25884.1742761832.diff
Sat, Mar 22, 20:30
F3224311: D25884.1742016554.diff
Fri, Mar 14, 05:29
F3221226: D25884.1741817259.diff
Tue, Mar 11, 22:07
View All 61 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPf9e5630bab68: Add some trivial Herald related PhpDoc comments
Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1722
Build 1722: arc lint + arc unit

Event Timeline

aklapper created this revision.Feb 16 2025, 23:34
Owners added a reviewer: O1: Blessed Committers.Feb 16 2025, 23:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 16 2025, 23:34
aklapper requested review of this revision.Feb 16 2025, 23:34
Harbormaster completed remote builds in B1716: Diff 2661.Feb 16 2025, 23:34
aklapper updated this revision to Diff 2662.Feb 16 2025, 23:36

I wonder what's wrong with my CSS/JS, sigh

Harbormaster completed remote builds in B1717: Diff 2662.Feb 16 2025, 23:36
aklapper added a comment.Feb 17 2025, 00:01

Okay, got to wait until D25885 is merged first

valerio.bozzolan accepted this revision.Feb 17 2025, 07:16

yesyes

This revision is now accepted and ready to land.Feb 17 2025, 07:16
aklapper updated this revision to Diff 2668.Feb 17 2025, 08:33

git rebase master

Harbormaster completed remote builds in B1722: Diff 2668.Feb 17 2025, 08:33
Closed by commit rPf9e5630bab68: Add some trivial Herald related PhpDoc comments. · Explain WhyFeb 17 2025, 08:34
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf9e5630bab68: Add some trivial Herald related PhpDoc comments.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
herald/
action/
3 lines1%
Loading...
O1: Blessed Committers
engine/
16 lines11%
Loading...
O1: Blessed Committers
storage/
3 lines12%
Loading...
O1: Blessed Committers

Diff 2668

View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/engine/HeraldEffect.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0