Page MenuHomePhorge

Add some trivial Herald related PhpDoc comments
ClosedPublic

Authored by aklapper on Sun, Feb 16, 23:34.
Tags
None
Referenced Files
F2991598: D25884.1740194691.diff
Fri, Feb 21, 03:24
F2988997: D25884.1740162427.diff
Thu, Feb 20, 18:27
F2988329: D25884.1740145181.diff
Thu, Feb 20, 13:39
F2984653: D25884.1740021073.diff
Wed, Feb 19, 03:11
F2983735: D25884.1739999048.diff
Tue, Feb 18, 21:04
F2982836: D25884.1739971965.diff
Tue, Feb 18, 13:32
F2982745: D25884.1739971749.diff
Tue, Feb 18, 13:29
F2981661: D25884.1739921451.diff
Mon, Feb 17, 23:30

Details

Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1716
Build 1716: arc lint + arc unit

Unit TestsFailed

TimeTest
656 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
389 msHeraldRuleTestCase::testHeraldRuleExecutionOrder
1 assertion passed.
387 msHeraldTranscriptTestCase::testTranscriptTruncation
5 assertions passed.
783 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
483 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
View Full Test Results (1 Failed · 8 Passed)

Event Timeline

I wonder what's wrong with my CSS/JS, sigh

Okay, got to wait until D25885 is merged first

This revision is now accepted and ready to land.Mon, Feb 17, 07:16