Page MenuHomePhorge

Add some trivial Herald related PhpDoc comments
ClosedPublic

Authored by aklapper on Feb 16 2025, 23:34.
Tags
None
Referenced Files
F3530192: D25884.1744871468.diff
Wed, Apr 16, 06:31
F3527201: D25884.1744834877.diff
Tue, Apr 15, 20:21
F3499024: D25884.1744793496.diff
Tue, Apr 15, 08:51
F3393212: D25884.1744494878.diff
Fri, Apr 11, 21:54
F3390547: D25884.1744468805.diff
Fri, Apr 11, 14:40
F3388253: D25884.1744445862.diff
Fri, Apr 11, 08:17
F3388252: D25884.1744445842.diff
Fri, Apr 11, 08:17
F3388251: D25884.1744445831.diff
Fri, Apr 11, 08:17

Details

Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1716
Build 1716: arc lint + arc unit

Unit TestsFailed

TimeTest
656 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
389 msHeraldRuleTestCase::testHeraldRuleExecutionOrder
1 assertion passed.
387 msHeraldTranscriptTestCase::testTranscriptTruncation
5 assertions passed.
783 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
483 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
View Full Test Results (1 Failed · 8 Passed)

Event Timeline

I wonder what's wrong with my CSS/JS, sigh

Okay, got to wait until D25885 is merged first

This revision is now accepted and ready to land.Feb 17 2025, 07:16