Page MenuHomePhorge

Add some trivial Herald related PhpDoc comments
ClosedPublic

Authored by aklapper on Feb 16 2025, 23:34.
Tags
None
Referenced Files
F4011888: D25884.1746626853.diff
Tue, May 6, 14:07
F3954815: D25884.1746457256.diff
Sun, May 4, 15:00
F3761281: D25884.1745830991.diff
Sun, Apr 27, 09:03
F3738966: D25884.1745762802.diff
Sat, Apr 26, 14:06
F3738954: D25884.1745762461.diff
Sat, Apr 26, 14:01
F3695562: D25884.1745591861.diff
Thu, Apr 24, 14:37
F3689813: D25884.1745590836.diff
Thu, Apr 24, 14:20
F3689799: D25884.1745590211.diff
Thu, Apr 24, 14:10

Details

Summary

Self-explanatory.

Test Plan

Read and play with code.

Diff Detail

Repository
rP Phorge
Branch
heraldPhpDocs (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1716
Build 1716: arc lint + arc unit

Unit TestsFailed

TimeTest
656 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
389 msHeraldRuleTestCase::testHeraldRuleExecutionOrder
1 assertion passed.
387 msHeraldTranscriptTestCase::testTranscriptTruncation
5 assertions passed.
783 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
483 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
View Full Test Results (1 Failed · 8 Passed)

Event Timeline

I wonder what's wrong with my CSS/JS, sigh

Okay, got to wait until D25885 is merged first

This revision is now accepted and ready to land.Feb 17 2025, 07:16