Differential D25861

Don't try to translate date elements used internally in AphrontFormDateControlValue
Needs ReviewPublic
Actions

Authored by pppery on Fri, Jan 10, 04:42.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15811: Search exception when AM/PM string is localized in Calendar application

Summary

Fixes T15811. Alternative to D25618

Test Plan

Observe that the lengthy steps to reproduce in T15811 no longer reproduce. Observe that translated date strings (e.p.p.) still appear in most parts of the interface

Diff Detail

Repository

rP Phorge

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/view/viewutils.php:111	TXT2	Tab Literal
Warning	src/view/viewutils.php:115	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 1671
Build 1671: arc lint + arc unit

Event Timeline

pppery created this revision.Fri, Jan 10, 04:42

Owners added a reviewer: O1: Blessed Committers.Fri, Jan 10, 04:42

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Jan 10, 04:42

pppery requested review of this revision.Fri, Jan 10, 04:42

Harbormaster completed remote builds in B1671: Diff 2601.Fri, Jan 10, 04:42

Fix lint

Harbormaster completed remote builds in B1672: Diff 2602.Fri, Jan 10, 04:44

pppery edited the test plan for this revision. (Show Details)Fri, Jan 10, 04:44

Thanks! If you remember which parts of the interface you've already tested, feel free to mention in the Test Plan, so I can maybe help in testing other parts

All I did was look at the homepage and observe I saw "e. p. p" in the recent activity (and thus the translations somehow worked). That was more of a paranoia check for unintended side effects on other uses of the function, to make sure I didn't break date translation completely. You're welcome to test other UI things to make sure they're not affected if you wish.

Actual forms in which the user enters dates/times still seem to only accept English, which is fine I guess.