Fix Diffusion commands in non-English environments
ClosedPublic
Actions

Authored by valerio.bozzolan on Thu, Dec 5, 15:43.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15966: Fix unit test PhabricatorChangeParserTestCase::testSubversionPartialParser for non-English terminals

Commits

rP14fcf61a1eee: Fix Diffusion commands in non-English environments

Summary

Closes T15966

Force Diffusion commands to be executed in the "LC_ALL=C" language mode, that is, English,
defusing whatever custom language you have in your LANGUAGE variable.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Thu, Dec 5, 15:43

Owners added a reviewer: O1: Blessed Committers.Thu, Dec 5, 15:43

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptThu, Dec 5, 15:43

valerio.bozzolan requested review of this revision.Thu, Dec 5, 15:43

Harbormaster completed remote builds in B1641: Diff 2556.Thu, Dec 5, 15:43

aklapper edited the test plan for this revision. (Show Details)Tue, Dec 10, 09:46

After installing subversion and setting LC_ALL instead of LANG I can finally reproduce on a Fedora 40 system:

Before:

[acko@fedora phorge (master $|u=)]$ LC_ALL=fr_FR.utf8 ../arcanist/bin/arc unit ./src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php
   FAIL  PhabricatorChangeParserTestCase::testSubversionPartialParser
EXCEPTION (CommandException): Command failed with error #1!
COMMAND
svn --non-interactive log --xml --quiet --limit 4 file:///tmp/pfkja9lhp6o488kw/trunk/@2

STDOUT
<?xml version="1.0" encoding="UTF-8"?>
<log>


STDERR
svn: E160013: Fichier non trouvé : révision 2, chemin '/trunk'

#0 /var/www/html/phorge/arcanist/src/future/exec/ExecFuture.php(341): ExecFuture->raiseResultError(Array)
#1 /var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php(495): ExecFuture->resolvex()
#2 /var/www/html/phorge/phorge/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php(256): PhabricatorRepository->execxRemoteCommand('...', 4, '...')
#3 /var/www/html/phorge/phorge/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php(71): PhabricatorRepositoryDiscoveryEngine->discoverSubversionCommits()
#4 /var/www/html/phorge/phorge/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php(53): PhabricatorRepositoryDiscoveryEngine->discoverCommitsWithLock()
#5 /var/www/html/phorge/phorge/src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php(971): PhabricatorRepositoryDiscoveryEngine->discoverCommits()
#6 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): PhabricatorChangeParserTestCase->testSubversionPartialParser()
#7 /var/www/html/phorge/arcanist/src/unit/engine/PhutilUnitTestEngine.php(69): PhutilTestCase->run()
#8 /var/www/html/phorge/arcanist/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php(148): PhutilUnitTestEngine->run()
#9 /var/www/html/phorge/arcanist/src/workflow/ArcanistUnitWorkflow.php(170): ArcanistConfigurationDrivenUnitTestEngine->run()
#10 /var/www/html/phorge/arcanist/scripts/arcanist.php(427): ArcanistUnitWorkflow->run()
#11 {main}
   SKIP  PhabricatorChangeParserTestCase::testMercurialParser
No binary "hg" found on this system, skipping test.
   PASS  333ms   PhabricatorChangeParserTestCase::testSubversionForeignStubsParser
   PASS  668ms   PhabricatorChangeParserTestCase::testGitParser
   PASS  273ms   PhabricatorChangeParserTestCase::testSubversionValidRootParser
   PASS  941ms   PhabricatorChangeParserTestCase::testSubversionParser

COVERAGE REPORT
     76%     src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

After:

[acko@fedora phorge (master $|u=)]$ LC_ALL=fr_FR.utf8 ../arcanist/bin/arc unit ./src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php
   PASS  828ms   PhabricatorChangeParserTestCase::testGitParser
   PASS  281ms   PhabricatorChangeParserTestCase::testSubversionValidRootParser
   PASS  929ms   PhabricatorChangeParserTestCase::testSubversionParser
   PASS  326ms   PhabricatorChangeParserTestCase::testSubversionForeignStubsParser
   SKIP  PhabricatorChangeParserTestCase::testMercurialParser
No binary "hg" found on this system, skipping test.
   PASS  260ms   PhabricatorChangeParserTestCase::testSubversionPartialParser

COVERAGE REPORT
     83%     src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

This revision is now accepted and ready to land.Tue, Dec 10, 09:52

Closed by commit rP14fcf61a1eee: Fix Diffusion commands in non-English environments. · Explain WhyWed, Dec 11, 07:33

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP14fcf61a1eee: Fix Diffusion commands in non-English environments.

valerio.bozzolan mentioned this in Next Up.Wed, Dec 11, 07:37