Page MenuHomePhorge

Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test
ClosedPublic

Authored by aklapper on Dec 5 2024, 18:04.
Tags
None
Referenced Files
F3329686: D25848.1743478935.diff
Mon, Mar 31, 03:42
F3328860: D25848.1743463236.diff
Sun, Mar 30, 23:20
F3325005: D25848.1743407450.diff
Sun, Mar 30, 07:50
F3324024: D25848.1743393708.diff
Sun, Mar 30, 04:01
F3323773: D25848.1743389857.diff
Sun, Mar 30, 02:57
F3322791: D25848.1743377572.diff
Sat, Mar 29, 23:32
F3321806: D25848.1743360759.diff
Sat, Mar 29, 18:52
F3314043: D25848.1743226520.diff
Fri, Mar 28, 05:35

Details

Summary

Explicitly cast $minutes to int to avoid an error in PHP 8.1 and later.

ERROR 8192: Implicit conversion from float to int loses precision at [/var/www/html/phorge/arcanist/src/unit/renderer/ArcanistUnitConsoleRenderer.php:86]

Closes T15968

Test Plan

Run bin/arc unit --everything.

Diff Detail

Repository
rARC Arcanist
Branch
T15968 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1647
Build 1647: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.Dec 5 2024, 18:04

lgtm

src/unit/renderer/ArcanistUnitConsoleRenderer.php
85–86

Or directly up :)

This revision is now accepted and ready to land.Dec 5 2024, 22:07