Paths

Table of Contentst

Differential D25848

Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test
ClosedPublic
Actions

Authored by aklapper on Dec 5 2024, 18:04.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails

Commits

rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test

Summary

Explicitly cast $minutes to int to avoid an error in PHP 8.1 and later.

ERROR 8192: Implicit conversion from float to int loses precision at [/var/www/html/phorge/arcanist/src/unit/renderer/ArcanistUnitConsoleRenderer.php:86]

Closes T15968

Test Plan

Run bin/arc unit --everything.

Diff Detail

Repository

rARC Arcanist

Branch

T15968 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1644
Build 1644: arc lint + arc unit

Event Timeline

aklapper created this revision.Dec 5 2024, 18:04

Owners added a reviewer: O1: Blessed Committers.Dec 5 2024, 18:04

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 5 2024, 18:04

aklapper requested review of this revision.Dec 5 2024, 18:04

Harbormaster completed remote builds in B1644: Diff 2560.Dec 5 2024, 18:04

lgtm

src/unit/renderer/ArcanistUnitConsoleRenderer.php
85–86	Or directly up :)

This revision is now accepted and ready to land.Dec 5 2024, 22:07

Uhm, right, heh

Harbormaster completed remote builds in B1646: Diff 2562.Dec 6 2024, 11:48

Oops, no for real

Harbormaster completed remote builds in B1647: Diff 2563.Dec 6 2024, 11:49

aklapper marked an inline comment as done.Dec 6 2024, 11:55

Double slam-accept

Closed by commit rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test. · Explain WhyDec 6 2024, 12:17

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.

aklapper mentioned this in D25856: Add explicit cast to ArcanistUnitConsoleRenderer unit test.Dec 19 2024, 10:36

aklapper mentioned this in rARCec68f53ba2d6: Add explicit cast to ArcanistUnitConsoleRenderer unit test.Jan 15 2025, 13:41

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

unit/

renderer/

ArcanistUnitConsoleRenderer.php

2 lines

61%

O1: Blessed Committers

Diff 2560

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit testClosedPublicActions