Page MenuHomePhorge
Differential D25833

APC: Set ttl to 0 when ttl is not given
ClosedPublic
Actions

Authored by mainframe98 on Oct 27 2024, 12:59.
Tags
None
Referenced Files
F2938215: D25833.1737980819.diff
Sun, Jan 26, 12:26
F2928744: D25833.1737652733.diff
Wed, Jan 22, 17:18
F2878252: D25833.1737019675.diff
Wed, Jan 15, 09:27
F2878251: D25833.1737019673.diff
Wed, Jan 15, 09:27
F2878250: D25833.1737019672.diff
Wed, Jan 15, 09:27
F2877641: D25833.1737004243.diff
Wed, Jan 15, 05:10
F2877604: D25833.1737003462.diff
Wed, Jan 15, 04:57
F2873012: D25833.1736907357.diff
Tue, Jan 14, 02:15
View All 11 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given
Summary

Passing null as a value for parameter $ttl is deprecated.
Omitting the parameter is considered to be equivalent to 0.

Bug: T15064

Test Plan
  • Looked in the deprecation log and did not see a deprecation message from apc.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 1613
Build 1613: arc lint + arc unit

Event Timeline

mainframe98 created this revision.Oct 27 2024, 12:59
Owners added a reviewer: O1: Blessed Committers.Oct 27 2024, 12:59
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 27 2024, 12:59
Harbormaster completed remote builds in B1612: Diff 2510.Oct 27 2024, 12:59
mainframe98 requested review of this revision.Oct 27 2024, 12:59
avivey accepted this revision.Oct 27 2024, 13:13
This revision is now accepted and ready to land.Oct 27 2024, 13:13
avivey added inline comments.Oct 27 2024, 13:13
src/infrastructure/cache/PhutilAPCKeyValueCache.php
41

let's also default to 0 here?

mainframe98 updated this revision to Diff 2511.Oct 27 2024, 14:03
  • APC: Change the setKeys $ttl parameter default to 0
Harbormaster completed remote builds in B1613: Diff 2511.Oct 27 2024, 14:03
mainframe98 marked an inline comment as done.Oct 27 2024, 14:03
mainframe98 added inline comments.
src/infrastructure/cache/PhutilAPCKeyValueCache.php
41

I was concerned that that might cause a deprecation warning about non-matching signatures, so I kept this change small.

avivey accepted this revision.Oct 27 2024, 14:06
Closed by commit rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given. · Explain WhyOct 27 2024, 14:12
This revision was automatically updated to reflect the committed changes.
mainframe98 marked an inline comment as done.
mainframe98 added a commit: rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given.

Revision Contents
Changeset List

PathSizePackages
src/
infrastructure/
cache/
6 linesO1: Blessed Committers

Diff 2511

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0