Paths

Table of Contentst

Differential D25833

APC: Set ttl to 0 when ttl is not given
ClosedPublic
Actions

Authored by mainframe98 on Oct 27 2024, 12:59.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Commits

rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given

Summary

Passing null as a value for parameter $ttl is deprecated.
Omitting the parameter is considered to be equivalent to 0.

Bug: T15064

Test Plan

Looked in the deprecation log and did not see a deprecation message from apc.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mainframe98 created this revision.Oct 27 2024, 12:59

Owners added a reviewer: O1: Blessed Committers.Oct 27 2024, 12:59

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 27 2024, 12:59

Harbormaster completed remote builds in B1612: Diff 2510.Oct 27 2024, 12:59

mainframe98 requested review of this revision.Oct 27 2024, 12:59

avivey accepted this revision.Oct 27 2024, 13:13

This revision is now accepted and ready to land.Oct 27 2024, 13:13

avivey added inline comments.Oct 27 2024, 13:13

src/infrastructure/cache/PhutilAPCKeyValueCache.php
41	let's also default to `0` here?

APC: Change the setKeys $ttl parameter default to 0

Harbormaster completed remote builds in B1613: Diff 2511.Oct 27 2024, 14:03

mainframe98 marked an inline comment as done.Oct 27 2024, 14:03

mainframe98 added inline comments.

src/infrastructure/cache/PhutilAPCKeyValueCache.php
41	I was concerned that that might cause a deprecation warning about non-matching signatures, so I kept this change small.

avivey accepted this revision.Oct 27 2024, 14:06

Closed by commit rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given. · Explain WhyOct 27 2024, 14:12

This revision was automatically updated to reflect the committed changes.

mainframe98 marked an inline comment as done.

mainframe98 added a commit: rP74bf6c0e3c2b: APC: Set ttl to 0 when ttl is not given.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

cache/

PhutilAPCKeyValueCache.php

6 lines

O1: Blessed Committers

Diff 2512

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php

APC: Set ttl to 0 when ttl is not givenClosedPublicActions