Paths

Table of Contentst

Differential D25826

Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view
ClosedPublic
Actions

Authored by aklapper on Tue, Oct 1, 15:10.

Tags

None

Referenced Files

	F2568285: D25826.1729348283.diff
	Fri, Oct 18, 14:31

	F2568260: D25826.1729347948.diff
	Fri, Oct 18, 14:25

	F2568016: D25826.1729340432.diff
	Fri, Oct 18, 12:20

Subscribers

valerio.bozzolan

Tokens

"Yellow Medal" token, awarded by 20after4.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view

Commits

rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit…

Summary

PhabricatorRepository::parseRepositoryServicePath() can return null per https://we.phorge.it/source/phorge/browse/master/src/applications/repository/storage/PhabricatorRepository.php;123831b53fb7572cba11e9c990dcb9d247614890$635, thus make the code in DiffusionServeController:getRequestDirectoryPath() at least not crash when handling null and instead fall back to serving a "403 This repository is read-only over HTTP."

There is probably a cleaner approach which I happily leave to any future person willing to figure it out.

Closes T15944

Test Plan

Go to http://phorge.localhost/rABCD0123456789abcdef0123456789abcdef01234567?service=foo

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Oct 1, 15:10

Owners added a reviewer: O1: Blessed Committers.Tue, Oct 1, 15:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Oct 1, 15:10

aklapper requested review of this revision.Tue, Oct 1, 15:10

Harbormaster completed remote builds in B1602: Diff 2489.Tue, Oct 1, 15:10

20after4 accepted this revision.Wed, Oct 9, 08:07

20after4 awarded a token.

This revision is now accepted and ready to land.Wed, Oct 9, 08:07

Closed by commit rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit…. · Explain WhyWed, Oct 9, 09:19

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

controller/

DiffusionServeController.php

12 lines

O1: Blessed Committers

repository/

storage/

PhabricatorRepository.php

3 lines

O1: Blessed Committers

Diff 2491

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...