Page MenuHomePhorge

Remove trivial cases of unreachable code
ClosedPublic

Authored by aklapper on Aug 24 2024, 08:49.
Tags
None
Referenced Files
F3657688: D25802.1745453062.diff
Wed, Apr 23, 00:04
F3657381: D25802.1745443515.diff
Tue, Apr 22, 21:25
F3503044: D25802.1744797726.diff
Tue, Apr 15, 10:02
F3387776: D25802.1744440759.diff
Fri, Apr 11, 06:52
F3375106: D25802.1744302951.diff
Wed, Apr 9, 16:35
F3340239: D25802.1743633078.diff
Tue, Apr 1, 22:31
F3334979: D25802.1743556300.diff
Tue, Apr 1, 01:11
F3319499: D25802.1743308056.diff
Sat, Mar 29, 04:14

Details

Summary

Static code analysis can detect Unreachable statement - code above always terminates.
The vast majority of occurrences in the Phorge codebase are due to an unreachable break within a case after a return or after an all-covering if/else.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan

Examine the code; run static code analysis.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable