Page MenuHomePhorge

Remove trivial cases of unreachable code
ClosedPublic

Authored by aklapper on Aug 24 2024, 08:53.
Tags
None
Referenced Files
F2995432: D25803.1740341528.diff
Sat, Feb 22, 20:12
F2995431: D25803.1740341528.diff
Sat, Feb 22, 20:12
F2995404: D25803.1740340460.diff
Sat, Feb 22, 19:54
F2995393: D25803.1740340029.diff
Sat, Feb 22, 19:47
F2951820: D25803.1738942159.diff
Thu, Feb 6, 15:29
F2934869: D25803.1737805581.diff
Fri, Jan 24, 11:46
F2932632: D25803.1737740158.diff
Jan 23 2025, 17:35
F2932628: D25803.1737740156.diff
Jan 23 2025, 17:35

Details

Summary

Static code analysis can detect Unreachable statement - code above always terminates.
The vast majority of occurrences in the Arcanist codebase are due to an unreachable break within a case after a return or after an all-covering if/else.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan

Examine the code; run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable