Page MenuHomePhorge

Remove trivial cases of unreachable code
ClosedPublic

Authored by aklapper on Aug 24 2024, 08:53.
Tags
None
Referenced Files
F3254919: D25803.1742488094.diff
Wed, Mar 19, 16:28
F3224427: D25803.1742026760.diff
Fri, Mar 14, 08:19
F3094683: D25803.1741101027.diff
Mon, Mar 3, 15:10
F3018579: D25803.1740772917.diff
Thu, Feb 27, 20:01
F3012752: D25803.1740682241.diff
Wed, Feb 26, 18:50
F2995432: D25803.1740341528.diff
Sat, Feb 22, 20:12
F2995431: D25803.1740341528.diff
Sat, Feb 22, 20:12
F2995404: D25803.1740340460.diff
Sat, Feb 22, 19:54

Details

Summary

Static code analysis can detect Unreachable statement - code above always terminates.
The vast majority of occurrences in the Arcanist codebase are due to an unreachable break within a case after a return or after an all-covering if/else.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan

Examine the code; run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable