Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode
ClosedPublic
Actions

Authored by aklapper on Aug 23 2024, 11:14.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests

Commits

rARCa0941059085e: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode

Summary

When $u is null, null is passed to preg_match() which is deprecated behavior since PHP 8.1.
Thus first check if $u === null.

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/api/XHPASTNode.php:243]

Refs T15926

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository

rARC Arcanist

Branch

pregmatchXHPASTNode

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1560
Build 1560: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	662 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'. #0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(85): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture)) #1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(634): ArcanistBundleTestCase->testGitRepository()
	45 ms	ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed.
	48 ms	ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed.
	43 ms	ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed.
	47 ms	ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed.
		View Full Test Results (1 Failed · 78 Passed)