Paths

Table of Contentst

Remove unused methods from ConpherenceDurableColumnView
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:46.

Tags

None

Referenced Files

	F3837213: D25784.1746089414.diff
	Wed, Apr 30, 08:50

	F3825424: D25784.1746027543.diff
	Tue, Apr 29, 15:39

	F3675114: D25784.1745499984.diff
	Wed, Apr 23, 13:06

	F3387603: D25784.1744439429.diff
	Fri, Apr 11, 06:30

	F3373614: D25784.1744273582.diff
	Wed, Apr 9, 08:26

	F3365343: D25784.1744173742.diff
	Tue, Apr 8, 04:42

	F3353280: D25784.1743831574.diff
	Fri, Apr 4, 05:39

	F3350319: D25784.1743765479.diff
	Thu, Apr 3, 11:17

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView

Summary

Calls to private methods ConpherenceDurableColumnView::buildStatusText() and ConpherenceDurableColumnView::buildSendButton() were removed in https://we.phorge.it/rP95d174956639aac7525d52368944edfff7cdb824

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

unusedMethods

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1534
Build 1534: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 06:46

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:46

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:46

aklapper requested review of this revision.Aug 16 2024, 06:46

Harbormaster completed remote builds in B1534: Diff 2379.Aug 16 2024, 06:46

sgtm

src/applications/conpherence/view/ConpherenceDurableColumnView.php
491	👀 wow. Useful in T15225

This revision is now accepted and ready to land.Aug 20 2024, 07:01

aklapper marked an inline comment as done.Aug 20 2024, 08:10

Closed by commit rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView. · Explain WhyAug 20 2024, 08:11

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView.

aklapper mentioned this in D25822: Documentation: add article about Javelin DOM stuff.Sep 10 2024, 11:33

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

conpherence/

view/

ConpherenceDurableColumnView.php

19 lines

O1: Blessed Committers

Diff 2379

View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Remove unused methods from ConpherenceDurableColumnViewClosedPublicActions