Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call
ClosedPublic
Actions

Authored by aklapper on Jul 25 2024, 13:54.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()…

Summary

Method PhabricatorDaemonController::buildSideNavView() invoked with 1 parameter, 0 required.
Thus remove the parameter from its call in the same class.

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Branch

daemonControllerSideNav

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1456
Build 1456: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 25 2024, 13:54

Owners added a reviewer: O1: Blessed Committers.Jul 25 2024, 13:54

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 25 2024, 13:54

aklapper requested review of this revision.Jul 25 2024, 13:54

Harbormaster completed remote builds in B1456: Diff 2270.Jul 25 2024, 13:54

aklapper retitled this revision from Remove parameter from PhabricatorDaemonController::buildSideNavView() call to Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call.Jul 25 2024, 13:56

valerio.bozzolan accepted this revision.Jul 26 2024, 10:11

This revision is now accepted and ready to land.Jul 26 2024, 10:11

Closed by commit rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()…. · Explain WhyJul 26 2024, 11:48

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()….