Paths

Table of Contentst

-
src/applications/daemon/controller/
-
applications/
-
daemon/
-
controller/
-
PhabricatorDaemonController.php

Differential D25746

Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call
ClosedPublic
Actions

Authored by aklapper on Jul 25 2024, 13:54.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()…

Summary

Method PhabricatorDaemonController::buildSideNavView() invoked with 1 parameter, 0 required.
Thus remove the parameter from its call in the same class.

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 25 2024, 13:54

Owners added a reviewer: O1: Blessed Committers.Jul 25 2024, 13:54

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 25 2024, 13:54

aklapper requested review of this revision.Jul 25 2024, 13:54

Harbormaster completed remote builds in B1456: Diff 2270.Jul 25 2024, 13:54

aklapper retitled this revision from Remove parameter from PhabricatorDaemonController::buildSideNavView() call to Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call.Jul 25 2024, 13:56

valerio.bozzolan accepted this revision.Jul 26 2024, 10:11

This revision is now accepted and ready to land.Jul 26 2024, 10:11

Closed by commit rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()…. · Explain WhyJul 26 2024, 11:48

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

daemon/

controller/

PhabricatorDaemonController.php

2 lines

O1: Blessed Committers

Diff 2274

View Options

src/applications/daemon/controller/PhabricatorDaemonController.php

	<?php			<?php

	abstract class PhabricatorDaemonController			abstract class PhabricatorDaemonController
	extends PhabricatorController {			extends PhabricatorController {

	public function shouldRequireAdmin() {			public function shouldRequireAdmin() {
	return true;			return true;
	}			}

	public function buildApplicationMenu() {			public function buildApplicationMenu() {
	return $this->buildSideNavView(true)->getMenu();			return $this->buildSideNavView()->getMenu();
	}			}

	protected function buildSideNavView() {			protected function buildSideNavView() {
	$nav = new AphrontSideNavFilterView();			$nav = new AphrontSideNavFilterView();
	$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));			$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));

	$nav->addLabel(pht('Daemons'));			$nav->addLabel(pht('Daemons'));
	$nav->addFilter('/', pht('Console'));			$nav->addFilter('/', pht('Console'));
	Show All 9 Lines

Remove unused parameter from PhabricatorDaemonController::buildSideNavView() callClosedPublicActions