Page MenuHomePhorge
Differential D25741

Fix undefined variable in HeraldAction
ClosedPublic
Actions

Authored by aklapper on Jul 24 2024, 15:48.
Tags
None
Referenced Files
F4011656: D25741.1746626346.diff
Tue, May 6, 13:59
F3730626: D25741.1745733586.diff
Sat, Apr 26, 05:59
F3702275: D25741.1745621895.diff
Thu, Apr 24, 22:58
F3702165: D25741.1745618869.diff
Thu, Apr 24, 22:07
F3702003: D25741.1745613183.diff
Thu, Apr 24, 20:33
F3675950: D25741.1745533533.diff
Wed, Apr 23, 22:25
F3605502: D25741.1745272722.diff
Sun, Apr 20, 21:58
F3500335: D25741.1744794500.diff
Tue, Apr 15, 09:08
View All 47 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP0b93685cc999: Fix undefined variable in HeraldAction
Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
herald/
action/
7 linesO1: Blessed Committers

Diff 2266

View Options

src/applications/herald/action/HeraldAction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0