Paths

Table of Contentst

Fix undefined variable in HeraldAction
ClosedPublic
Actions

Authored by aklapper on Jul 24 2024, 15:48.

Tags

None

Referenced Files

	F3500335: D25741.1744794500.diff
	Tue, Apr 15, 09:08

	F3396312: D25741.1744525248.diff
	Sat, Apr 12, 06:20

	F3389167: D25741.1744454259.diff
	Fri, Apr 11, 10:37

	F3388972: D25741.1744450716.diff
	Fri, Apr 11, 09:38

	F3370627: D25741.1744229042.diff
	Tue, Apr 8, 20:04

	F3368334: D25741.1744207832.diff
	Tue, Apr 8, 14:10

	F3367670: D25741.1744202471.diff
	Tue, Apr 8, 12:41

	F3359541: D25741.1743949508.diff
	Sat, Apr 5, 14:25

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP0b93685cc999: Fix undefined variable in HeraldAction

Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 24 2024, 15:48

Owners added a reviewer: O1: Blessed Committers.Jul 24 2024, 15:48

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 24 2024, 15:48

aklapper requested review of this revision.Jul 24 2024, 15:48

Harbormaster completed remote builds in B1451: Diff 2264.Jul 24 2024, 15:48

sgtm

This revision is now accepted and ready to land.Jul 25 2024, 10:12

Closed by commit rP0b93685cc999: Fix undefined variable in HeraldAction. · Explain WhyJul 25 2024, 12:41

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP0b93685cc999: Fix undefined variable in HeraldAction.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

herald/

action/

HeraldAction.php

7 lines

O1: Blessed Committers

Diff 2266

View Options

src/applications/herald/action/HeraldAction.php

Fix undefined variable in HeraldActionClosedPublicActions