Page MenuHomePhorge

Fix undefined variable in HeraldAction
ClosedPublic

Authored by aklapper on Jul 24 2024, 15:48.

Details

Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Branch
undefinedVars
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1451
Build 1451: arc lint + arc unit