Page MenuHomePhorge

Fix undefined variable in HeraldAction
ClosedPublic

Authored by aklapper on Jul 24 2024, 15:48.
Tags
None
Referenced Files
F3341378: D25741.1743652538.diff
Wed, Apr 2, 03:55
F3338082: D25741.1743598579.diff
Tue, Apr 1, 12:56
F3330063: D25741.1743483395.diff
Mon, Mar 31, 04:56
F3322548: D25741.1743374293.diff
Sat, Mar 29, 22:38
F3314512: D25741.1743230695.diff
Fri, Mar 28, 06:44
F3313414: D25741.1743219037.diff
Fri, Mar 28, 03:30
F3312646: D25741.1743213085.diff
Fri, Mar 28, 01:51
F3295292: D25741.1742953283.diff
Tue, Mar 25, 01:41

Details

Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Branch
undefinedVars
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1451
Build 1451: arc lint + arc unit