Page MenuHomePhorge
Differential D25729

Remove unreachable return statement in AphrontFormDateControlValue
ClosedPublic
Actions

Authored by aklapper on Jul 10 2024, 13:25.
Tags
None
Referenced Files
F3729992: D25729.1745731551.diff
Sat, Apr 26, 05:25
F3721436: D25729.1745720537.diff
Sat, Apr 26, 02:22
F3712554: D25729.1745687157.diff
Fri, Apr 25, 17:05
F3712465: D25729.1745682333.diff
Fri, Apr 25, 15:45
F3709288: D25729.1745646360.diff
Fri, Apr 25, 05:46
F3681891: D25729.1745562546.diff
Thu, Apr 24, 06:29
F3523940: D25729.1744817477.diff
Tue, Apr 15, 15:31
F3434946: D25729.1744673659.diff
Sun, Apr 13, 23:34
View All 52 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue
Summary

Two unconditional return statements lead to never reaching the second one.

Test Plan

Read the code of this method.

Diff Detail

Repository
rP Phorge
Branch
aphrontFormDatedoubleReturn
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1434
Build 1434: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
view/
form/
control/
2 lines1%
Loading...
O1: Blessed Committers

Diff 2237

View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0