Differential D25729

Remove unreachable return statement in AphrontFormDateControlValue
ClosedPublic
Actions

Authored by aklapper on Jul 10 2024, 13:25.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Commits

rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue

Summary

Two unconditional return statements lead to never reaching the second one.

Test Plan

Read the code of this method.

Diff Detail

Repository

rP Phorge

Branch

aphrontFormDatedoubleReturn

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1434
Build 1434: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 10 2024, 13:25

Owners added a reviewer: O1: Blessed Committers.Jul 10 2024, 13:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 10 2024, 13:25

aklapper requested review of this revision.Jul 10 2024, 13:25

Harbormaster completed remote builds in B1434: Diff 2237.Jul 10 2024, 13:25

avivey accepted this revision.Jul 10 2024, 13:53

This revision is now accepted and ready to land.Jul 10 2024, 13:53

Closed by commit rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue. · Explain WhyJul 10 2024, 13:56

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

view/

form/

control/

AphrontFormDateControlValue.php

2 lines

O1: Blessed Committers

Diff 2237

View Options

src/view/form/control/AphrontFormDateControlValue.php

Remove unreachable return statement in AphrontFormDateControlValueClosedPublicActions