Page MenuHomePhorge

Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
ClosedPublic

Authored by aklapper on Jul 9 2024, 21:26.
Tags
None
Referenced Files
F3748877: D25727.1745786489.diff
Sat, Apr 26, 20:41
F3738947: D25727.1745762018.diff
Sat, Apr 26, 13:53
F3720131: D25727.1745697262.diff
Fri, Apr 25, 19:54
F3717105: D25727.1745694712.diff
Fri, Apr 25, 19:11
F3717055: D25727.1745692295.diff
Fri, Apr 25, 18:31
F3712483: D25727.1745683134.diff
Fri, Apr 25, 15:58
F3701853: D25727.1745608740.diff
Thu, Apr 24, 19:19
F3679021: D25727.1745550438.diff
Thu, Apr 24, 03:07

Details

Summary

The expression $all_tags[$tag]['count'] does not do anything. Reading the surrounding code, intention is to display a "Common" section on /settings/panel/emailpreferences/ listing MailTags defined by at least two different applications. (This is currently not the case anyway as Phorge prefixes all MailTags with their corresponding application but might be a future use case.)
This change fixes the logic accordingly.

Closes T15874

Test Plan

Apply the patch; replace the value of a random const MAILTAG_* line in the codebase with the value of another random const MAILTAG_* line in the codebase to make it "common", now see that /settings/panel/emailpreferences/ displays this MailTag in a "Common" section on top of the options.

Diff Detail

Repository
rP Phorge
Branch
T15874logic
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1429
Build 1429: arc lint + arc unit