Page MenuHomePhorge

Declare missing class properties in ArcanistDownloadWorkflow
ClosedPublic

Authored by aklapper on Jul 2 2024, 19:00.
Tags
None
Referenced Files
F2991904: D25713.1740198719.diff
Fri, Feb 21, 04:31
F2991903: D25713.1740198718.diff
Fri, Feb 21, 04:31
F2990362: D25713.1740177342.diff
Thu, Feb 20, 22:35
F2981961: D25713.1739943122.diff
Tue, Feb 18, 05:32
F2979179: D25713.1739800892.diff
Sun, Feb 16, 14:01
F2935753: D25713.1737868319.diff
Sat, Jan 25, 05:11
F2931742: D25713.1737724977.diff
Jan 23 2025, 13:22
F2929708: D25713.1737664239.diff
Jan 22 2025, 20:30

Details

Summary

rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties $id, $saveAs, $show.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in didParseArguments().

Test Plan

Run PHPStan static code analysis; grep the code in this class.

Diff Detail

Repository
rARC Arcanist
Branch
phpUndefinedPropertiesArcWorkflow
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1413
Build 1413: arc lint + arc unit