Page MenuHomePhorge

Declare missing class properties in ArcanistDownloadWorkflow
ClosedPublic

Authored by aklapper on Jul 2 2024, 19:00.

Details

Summary

rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties $id, $saveAs, $show.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in didParseArguments().

Test Plan

Run PHPStan static code analysis; grep the code in this class.

Diff Detail

Repository
rARC Arcanist
Branch
phpUndefinedPropertiesArcWorkflow
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1413
Build 1413: arc lint + arc unit