Page MenuHomePhorge

Declare missing class properties in ArcanistDownloadWorkflow
ClosedPublic

Authored by aklapper on Jul 2 2024, 19:00.
Tags
None
Referenced Files
F3349997: D25713.1743761699.diff
Thu, Apr 3, 10:14
F3334002: D25713.1743542756.diff
Mon, Mar 31, 21:25
F3332944: D25713.1743528833.diff
Mon, Mar 31, 17:33
F3328396: D25713.1743456232.diff
Sun, Mar 30, 21:23
F3328262: D25713.1743452501.diff
Sun, Mar 30, 20:21
F3327854: D25713.1743446588.diff
Sun, Mar 30, 18:43
F3322623: D25713.1743375239.diff
Sat, Mar 29, 22:53
F3309552: D25713.1743186702.diff
Thu, Mar 27, 18:31

Details

Summary

rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties $id, $saveAs, $show.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in didParseArguments().

Test Plan

Run PHPStan static code analysis; grep the code in this class.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable