Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine
ClosedPublic

Authored by aklapper on Jun 24 2024, 13:15.
Tags
None
Referenced Files
F4018592: D25699.1746662079.diff
Tue, May 6, 23:54
F4017077: D25699.1746652468.diff
Tue, May 6, 21:14
F4011564: D25699.1746626148.diff
Tue, May 6, 13:55
F3915074: D25699.1746350978.diff
Sat, May 3, 09:29
F3801767: D25699.1745963946.diff
Mon, Apr 28, 21:59
F3776922: D25699.1745865729.diff
Sun, Apr 27, 18:42
F3763167: D25699.1745839001.diff
Sun, Apr 27, 11:16
F3759298: D25699.1745827667.diff
Sun, Apr 27, 08:07

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1923]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:2023]

Closes T15864

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable