Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine
ClosedPublic

Authored by aklapper on Jun 24 2024, 13:15.
Tags
None
Referenced Files
F2995759: D25699.1740352140.diff
Sat, Feb 22, 23:09
F2995758: D25699.1740352139.diff
Sat, Feb 22, 23:08
F2995648: D25699.1740348721.diff
Sat, Feb 22, 22:12
F2995612: D25699.1740346606.diff
Sat, Feb 22, 21:36
F2943503: D25699.1738196736.diff
Wed, Jan 29, 00:25
F2935257: D25699.1737838614.diff
Fri, Jan 24, 20:56
F2934936: D25699.1737810609.diff
Jan 24 2025, 13:10
F2934780: D25699.1737803265.diff
Jan 24 2025, 11:07

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1923]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:2023]

Closes T15864

Test Plan

Diff Detail

Repository
rP Phorge
Branch
T15864strlenEmptyComment (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1368
Build 1368: arc lint + arc unit